Fix HERMES_ENABLED in react-native-xcode.sh#34728
Closed
janicduplessis wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
Contributor
Base commit: 010da67 |
Base commit: 353b1b0 |
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This looks like a duplicate of #34675 right? |
Contributor
Author
|
It is, I didn’t see #34675. Funny that we have the exact same fix including the file capitalization change 😅 |
Contributor
Author
|
#34675 landed so this is not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_ENABLEDvalue is currently wrong when running in a normal project setup. When running grep the current directory is the project root directory, which is not where the Podfile.lock usually is ("$rootProject/ios"). To make sure to grep the right folder we can use thePODS_PODFILE_DIR_PATHenv provided by Cocoapods.Changelog
[General] [Fixed] - Fix HERMES_ENABLED in react-native-xcode.sh
Test Plan
Verify that hermes cli runs properly in a project with hermes enabled.